Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Raise OrganismNotSet instead of AssertionError when organism is not set #144

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 5, 2024

Fixes #142

  • Now raising a custom OrganismNotSet error which suppresses the django traceback.

@Zethson Zethson marked this pull request as ready for review November 5, 2024 10:55
Copy link

github-actions bot commented Nov 5, 2024

@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 10:56 Inactive
@falexwolf
Copy link
Member

I thought you wanted to avoid the traceback?

@falexwolf
Copy link
Member

@Zethson
Copy link
Member Author

Zethson commented Nov 5, 2024

This PR didn't aim at solving this issue yet (note that I hadn't linked the issue). I just noticed this while scrolling through the code. But yeah, I can just add this to this PR and hit 2 birds with 1 stone :)

@Zethson Zethson marked this pull request as draft November 5, 2024 11:11
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 13:38 Inactive
@Zethson Zethson marked this pull request as ready for review November 5, 2024 13:40
@Zethson Zethson changed the title 🎨 Raise ValueError instead of AssertionError when not passing an organism 🎨 Raise OrganismNotSet instead of AssertionError when organism is not set Nov 5, 2024
@Zethson Zethson merged commit 893c6b4 into main Nov 5, 2024
4 checks passed
@Zethson Zethson deleted the fix/error branch November 5, 2024 13:55
@falexwolf
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce specify organism error message
2 participants